fix: add general API endpoints for Z.ai provider #9894

roomote · 2025-12-06T20:33:24Z

This PR attempts to address Issue #9879. Feedback and guidance are welcome.

Problem

The Z.ai provider currently only shows coding plan endpoints but not the regular API endpoints. Users who are using API billing need access to the standard API endpoints.

Solution

Added two new API line options to support regular API billing:

international_api: https://api.z.ai/api/paas/v4
china_api: https://open.bigmodel.cn/api/paas/v4

Changes

Added new API line options to zaiApiLineSchema in packages/types/src/provider-settings.ts
Added corresponding endpoint configurations to zaiApiLineConfigs in packages/types/src/providers/zai.ts
Updated display names to distinguish between "Coding" and "API" endpoints for clarity
Added comprehensive tests for the new API endpoints in src/api/providers/__tests__/zai.spec.ts

Testing

All existing tests pass
Added new test cases for both international_api and china_api endpoints
Verified correct base URLs are used for each endpoint
Confirmed proper model selection based on region

Fixes #9879

Important

Add international_api and china_api endpoints for Z.ai provider with tests and configuration updates.

Behavior:
- Added international_api and china_api endpoints to zaiApiLineSchema in provider-settings.ts.
- Updated zaiApiLineConfigs in zai.ts with new endpoint configurations.
- Updated display names for clarity between "Coding" and "API" endpoints.
Testing:
- Added tests for international_api and china_api in zai.spec.ts.
- Verified correct base URLs and API key usage for new endpoints.
- Confirmed model selection and configuration for both new endpoints.
Misc:
- All existing tests pass.

^{This description was created by}^{for ab9d34f. You can customize this summary. It will automatically update as commits are pushed.}

- Add international_api and china_api options to zaiApiLineSchema - Add corresponding endpoint configurations to zaiApiLineConfigs - Update display names to distinguish between Coding and API endpoints - Add comprehensive tests for new API endpoints Fixes #9879

roomote · 2025-12-06T20:33:48Z

Rooviewer See task on Roo Cloud

Review completed. Found 1 issue that needs attention:

Verify China API endpoint URL - the issue specifies pass but implementation uses paas

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

packages/types/src/providers/zai.ts

richtong · 2025-12-07T04:45:23Z

Ye that's correct a typo in original issue. Fixed. Should be paas

mrubens · 2025-12-07T05:04:31Z

@hannesrudolph @richtong looks like we removed the other two endpoints here, but I can't remember why: #8693.

@richtong just to confirm - you have an API key that works with the regular endpoint and not the coding endpoint?

hannesrudolph · 2025-12-07T05:05:33Z

@hannesrudolph @richtong looks like we removed the other two endpoints here, but I can't remember why: #8693.

@richtong just to confirm - you have an API key that works with the regular endpoint and not the coding endpoint?

They told us to as they would manage the switching at their end

richtong · 2025-12-07T18:02:19Z

Hmm well they haven't yet and their documentation says to use the two. We have a full API account so want to use that one. See https://docs.z.ai/guides/develop/http/introduction We confirmed this is true if you present an API key for an account only with API billing you get a "rate limited error" when presenting to the "coding" endpoint. —- API Basic Information General API Endpoint https://api.z.ai/api/paas/v4/ Note: When using the GLM Coding Plan, you need to configure the dedicated Coding endpoint - https://api.z.ai/api/coding/paas/v4 instead of the general endpoint - https://api.z.ai/api/paas/v4 Note: The Coding API endpoint is only for Coding scenarios and is not applicable to general API scenarios. Please use them accordingly. —- Sent via Superhuman ( ***@***.*** )

…

On Sat, Dec 6, 2025 at 21:05, Hannes Rudolph < ***@***.*** > wrote: *hannesrudolph* left a comment (RooCodeInc/Roo-Code#9894) ( #9894 (comment) ) > > > @hannesrudolph ( https://github.com/hannesrudolph ) @richtong ( > https://github.com/richtong ) looks like we removed the other two endpoints > here, but I can't remember why: #8693 ( > #8693 ). > > > > @richtong ( https://github.com/richtong ) just to confirm - you have an API > key that works with the regular endpoint and not the coding endpoint? > > They told us to as they would manage the switching at their end — Reply to this email directly, view it on GitHub ( #9894 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AANTCRZTRLHYJAI7QZIMW2D4AOYTHAVCNFSM6AAAAACOIFUIPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRRGYYTIMBWHA ). You are receiving this because you were mentioned. Message ID: <RooCodeInc/Roo-Code/pull/9894/c3621614068 @ github. com>

richtong · 2025-12-07T18:04:57Z

You could also just slow a typing in of an endpoint if you like :-) Sent via Superhuman ( ***@***.*** )

…

On Sun, Dec 7, 2025 at 10:02, Rich Tong < ***@***.*** > wrote: Hmm well they haven't yet and their documentation says to use the two. We have a full API account so want to use that one. See https://docs.z.ai/guides/develop/http/introduction We confirmed this is true if you present an API key for an account only with API billing you get a "rate limited error" when presenting to the "coding" endpoint. —- API Basic Information General API Endpoint https://api.z.ai/api/paas/v4/ Note: When using the GLM Coding Plan, you need to configure the dedicated Coding endpoint - https://api.z.ai/api/coding/paas/v4 instead of the general endpoint - https://api.z.ai/api/paas/v4 Note: The Coding API endpoint is only for Coding scenarios and is not applicable to general API scenarios. Please use them accordingly. —- Sent via Superhuman ( ***@***.*** ) On Sat, Dec 6, 2025 at 21:05, Hannes Rudolph < ***@***.*** > wrote: > *hannesrudolph* left a comment (RooCodeInc/Roo-Code#9894) ( > #9894 (comment) ) > > >> >> >> @hannesrudolph ( https://github.com/hannesrudolph ) @richtong ( >> https://github.com/richtong ) looks like we removed the other two endpoints >> here, but I can't remember why: #8693 ( >> #8693 ). >> >> >> >> @richtong ( https://github.com/richtong ) just to confirm - you have an API >> key that works with the regular endpoint and not the coding endpoint? >> >> > > > > They told us to as they would manage the switching at their end > > > > — > Reply to this email directly, view it on GitHub ( > #9894 (comment) ) > , or unsubscribe ( > https://github.com/notifications/unsubscribe-auth/AANTCRZTRLHYJAI7QZIMW2D4AOYTHAVCNFSM6AAAAACOIFUIPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRRGYYTIMBWHA > ). > You are receiving this because you were mentioned. Message ID: <RooCodeInc/Roo-Code/pull/9894/c3621614068 > @ github. com> > > >

richtong · 2025-12-09T19:58:32Z

@hannesrudolph @richtong looks like we removed the other two endpoints here, but I can't remember why: #8693.

@richtong just to confirm - you have an API key that works with the regular endpoint and not the coding endpoint?

Yes that's correct, we an API key that only works with regular endpoints and not the coding endpoints, so be nice to allow those urls as well :-)

richtong · 2025-12-10T05:09:35Z

@mrubens yes just confirmed we need the api end point with z.ai

@hannesrudolph @richtong looks like we removed the other two endpoints here, but I can't remember why: #8693.

@richtong just to confirm - you have an API key that works with the regular endpoint and not the coding endpoint?

roomote · 2025-12-10T05:10:55Z

Hi @mrubens and @hannesrudolph,

Based on the discussion, it appears that:

The user (@richtong) has confirmed they need the regular API endpoints - They have an API key that only works with the regular endpoints (not the coding endpoints)
The Z.ai documentation confirms this distinction - Per their docs at https://docs.z.ai/guides/develop/http/introduction, they specify:
- General API endpoint: https://api.z.ai/api/paas/v4/
- Coding endpoint: https://api.z.ai/api/coding/paas/v4/ (only for Coding Plan users)
The user gets rate limit errors when trying to use their API key with the coding endpoint

While PR #8693 previously removed these endpoints based on Z.ai's indication they would handle switching at their end, it seems this hasn't been implemented yet, and users with API-only accounts still need access to the regular endpoints.

This PR adds back the regular API endpoints to support users with API billing accounts. All tests are passing and the implementation looks good.

Could we get this reviewed for approval? This would unblock users who have API-only accounts with Z.ai.

cc: @richtong

roomote · 2025-12-11T06:51:43Z

Rooviewer See task on Roo Cloud

Review completed. No issues found.

The previous concern about paas vs pass in the URL has been resolved - @richtong confirmed that paas (Platform as a Service) is the correct path per Z.ai documentation.

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

hannesrudolph

Code Review Needed

github-project-automation bot added this to Roo Code Roadmap Dec 6, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Dec 6, 2025

github-project-automation bot added this to Roo Code Roadmap Dec 6, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Dec 6, 2025

roomote bot mentioned this pull request Dec 6, 2025

[BUG] Z.ai Provider does not show general API endpoint (only has coding plan endpoints) #9879

Closed

4 tasks

roomote bot commented Dec 6, 2025

View reviewed changes

packages/types/src/providers/zai.ts Show resolved Hide resolved

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 6, 2025

hannesrudolph moved this from Triage to PR [Needs Review] in Roo Code Roadmap Dec 11, 2025

hannesrudolph marked this pull request as ready for review December 11, 2025 06:51

hannesrudolph requested review from cte, jr and mrubens as code owners December 11, 2025 06:51

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Dec 11, 2025

hannesrudolph approved these changes Dec 11, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2025

hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Dec 11, 2025

mrubens approved these changes Dec 11, 2025

View reviewed changes

cte mentioned this pull request Dec 11, 2025

Release v3.36.5 #10029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add general API endpoints for Z.ai provider #9894

fix: add general API endpoints for Z.ai provider #9894

Uh oh!

roomote bot commented Dec 6, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot commented Dec 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

richtong commented Dec 7, 2025

Uh oh!

mrubens commented Dec 7, 2025 •

edited

Loading

Uh oh!

hannesrudolph commented Dec 7, 2025

Uh oh!

richtong commented Dec 7, 2025 via email

Uh oh!

richtong commented Dec 7, 2025 via email

Uh oh!

richtong commented Dec 9, 2025

Uh oh!

richtong commented Dec 10, 2025

Uh oh!

roomote bot commented Dec 10, 2025

Uh oh!

roomote bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

hannesrudolph left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: add general API endpoints for Z.ai provider #9894

fix: add general API endpoints for Z.ai provider #9894

Uh oh!

Conversation

roomote bot commented Dec 6, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Changes

Testing

Uh oh!

roomote bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

richtong commented Dec 7, 2025

Uh oh!

mrubens commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannesrudolph commented Dec 7, 2025

Uh oh!

richtong commented Dec 7, 2025 via email

Uh oh!

richtong commented Dec 7, 2025 via email

Uh oh!

richtong commented Dec 9, 2025

Uh oh!

richtong commented Dec 10, 2025

Uh oh!

roomote bot commented Dec 10, 2025

Uh oh!

roomote bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannesrudolph left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roomote bot commented Dec 6, 2025 •

edited by ellipsis-dev bot

Loading

roomote bot commented Dec 6, 2025 •

edited

Loading

mrubens commented Dec 7, 2025 •

edited

Loading

roomote bot commented Dec 11, 2025 •

edited

Loading